search

Shopify / slate

Slate is a toolkit for developing Shopify themes. It's designed to assist your workflow and speed up the process of developing, testing, and deploying themes.
https://shopify.github.io/slate
MIT License
1.28k stars 364 forks source link

Fix lax checking of filename against genericTemplateName in sections plugin #1008

Closed andyexeter closed 5 years ago

andyexeter commented 5 years ago

The sections plugin was performing a lax check on the section filename against the genericTemplateName option, using the includes() method to see if the relativePathFromSections argument includes the genericTemplateName option value anywhere within it.

This meant files such as src/sections/collection-template.liquid were compiled to dist/sections/collection-template.liquid.liquid and were not being updated on Shopify when changes were made locally with yarn start running.

This fix compares the basename of the relativePathFromSections argument instead.

Checklist

For contributors:

For maintainers:

andyexeter commented 5 years ago

I've signed the CLA - not sure what I need to do to get the check to run again.

Maurice-JB commented 5 years ago

Just checking -- what is the status of this PR? I can see it's been merged into Master but running yarn upgrade --latest @shopify/slate-tools doesn't seem to update the package.json or update any dependencies...

wizardlyhel commented 5 years ago

@Maurice-JB Working on it (This week). I'm fiddling with auto deploy configurations.

lock[bot] commented 5 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.