search

Shopify / slate

Slate is a toolkit for developing Shopify themes. It's designed to assist your workflow and speed up the process of developing, testing, and deploying themes.
https://shopify.github.io/slate
MIT License
1.28k stars 364 forks source link

Disable HSTS for dev server #1046

Closed stevekanter closed 4 years ago

stevekanter commented 4 years ago

Most other non-Slate 1.x development is via HTTP so by having HSTS on it really makes Shopify development tricky.

This repo is currently on low maintenance. See README for details

What are you trying to accomplish with this PR?

Most non-Shopify Slate 1.x development is done via HTTP. By leaving on Shopify's HSTS policy, it forces any localhost visits to happen via HTTPS. This simply removes that header from Shopify's proxied response so that HTTPS and HTTP can be used on localhost without issue.

Please provide a link to the associated GitHub issue. https://github.com/Shopify/slate/issues/906

Checklist

For contributors:

For maintainers:

t-kelly commented 4 years ago

Brilliant! 👍

lock[bot] commented 4 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.