Shopify / slate

Slate is a toolkit for developing Shopify themes. It's designed to assist your workflow and speed up the process of developing, testing, and deploying themes.
https://shopify.github.io/slate
MIT License
1.28k stars 364 forks source link

Slate-tools using themekit 0.6.12 #1057

Open JTimNolan opened 5 years ago

JTimNolan commented 5 years ago

Problem

Slate-tools is using a very old version of themekit. This seems to be causing some sort of issue for us when uploading our /config/settings_data.json file with it.

Replication steps

Run yarn watch Update settings_data.json In the background, the themekit command is run, but the file is not updated on Shopify Running the same command with the current version of themekit 1.0.1 does update the file in shopify

More Information

I'm running slate on windows - aware this isn't tested/officially supported but other than this issue it's been working fine (and themekit should actually work on windows anyway).

I'm happy to submit a PR for this, but I wanted to check if there was any reason for using an old version of themekit before doing so

Edit - ended up fixing and patching this for my team anyway - so submitted #1058