Shopify / slate

Slate is a toolkit for developing Shopify themes. It's designed to assist your workflow and speed up the process of developing, testing, and deploying themes.
https://shopify.github.io/slate
MIT License
1.28k stars 363 forks source link

End of support message #1091

Closed wizardlyhel closed 4 years ago

wizardlyhel commented 4 years ago

After re-evaluating Slate and its current state, Shopify has decided to officially end support for Slate.

Why?

With the launch of our new section theme architecture we're taking a step back to examine our current tooling and how we can deliver the best theming experience to our theme developers.

Slate is not in line with our vision for themes moving forward and it does not solve two of the larger asks our theme developers have made:

Iโ€™m a theme developer that is using Slate. What should I do now?

Slate was built upon Theme Kit as an opinionated way to setup up a Shopify theme build. Shopify will continue to actively maintain and support the growth of Theme Kit through the open-source community.

You can continue using Slate the way you have been. While we will not be maintaining it any longer, you can still fork the repo to suit your own needs.

dan-gamble commented 4 years ago

Can't say it's not disappointing but thank you for clarifying the state of Slate.

PaulNewton commented 4 years ago

Themekit while amazing is just a small critical part of tooling for alot of themes, with it's main drawback being that since it's themekit is made with GO the population of possible contributors goes way down.

@wizardlyhel

Support for code versioning within themes

Is that meaning the ask is support for versioning natively on shopify itself? and things like locksfiles or permissions? OR is that developers|teams are having trouble inherently using version-control with either slate itself or the theme system|admin?

Trying to get a feel if for most this is

wizardlyhel commented 4 years ago

@PaulNewton

It's the complexity of where the code is being updated. You, as a theme developer, have no guarantee at any point in time that your theme code is the latest version. This is due to the fact that at any giving point in time, theme code can be altered by:

joniler commented 4 years ago

@wizardlyhel this has been a gripe of mine with the Shopify ecosystem in general. Agencies should be able to disable some of these features and receive heads up on these things when working with enterprise clients.

Agencies and client Plus accounts should have more granular control. I understand that this is hard due to the thoughts behind what your ecosystem is... But we have had multiple clients who have installed third party apps and then we have to go and cherry pick code to merge it into our version control. This is bad. If a Shopify account codebase is being managed by an agency, there should be mechanisms in place to notify us when the client wishes to change theme code via an app install/setup, which files will change, and what code will go in. That way we can pre-populate our codebase for the app being installed. In terms of clients directly editing code... This should be able to be disabled as a safeguard.

PaulNewton commented 4 years ago

@joniler

we have to go and cherry pick code to merge it into our version control

Is this part due to the using a a build process and the theme output itself not always being in version control? Or that you also need to back-propagate|reverse-engineer whatever liquid was added into your frameworks language and logic to then put that into VCS?

jonathanmoore commented 4 years ago

@PaulNewton From our perspective, it is the later. It is not uncommon or unusual for a Shopify App install to automatically inject 1,000s of lines of new code across newly introduced files as well as modify virtually every theme file.

For a perfect example of this, set up a fresh theme, install any of Bold's apps as a trial and see how dramatically the code is modified. Right now there is no way to pull that code back into version control without a lot of manual work.

dan-thesill commented 4 years ago

https://github.com/Shopify/slate/pull/1001

This low maintenance period is time-boxed to 6 months from March 2019. We will re-visit and re-evaluate the project priority and plans for next steps.

Please manage expectations better in the future, knowing how well-used Shopify Slate is by stores, the lack of updates after this announced time-box left a lot of room for interpretation.

Similarly to Shopify, we would like to allocate engineering resources appropriately.

james2doyle commented 4 years ago

Screen Shot 2020-02-19 at 10 32 51 AM

I just had a back and forth with support and they are saying they donโ€™t fully support themekit. Maybe this was incorrect but it seems concerning...

james2doyle commented 4 years ago

@wizardlyhel why not assign community maintainers instead of letting the project sit? There are probably lots of competent developers who could take up the project and do a great job.

That is the benefit of making things open source in the first place...

lock[bot] commented 4 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.