search

Shopify / slate

Slate is a toolkit for developing Shopify themes. It's designed to assist your workflow and speed up the process of developing, testing, and deploying themes.
https://shopify.github.io/slate
MIT License
1.28k stars 365 forks source link

Installing Node Modules does not appear in node_modules #381

Closed patrickbjohnson closed 6 years ago

patrickbjohnson commented 6 years ago

Problem

When trying to run npm i --save <PACKAGE NAME> the package never downloads to Slate's node_modules directory.

Replication steps

  1. Open terminal and the install Flickity package: npm i --save flickity
  2. Upon successful installation (no errors in terminal), review the node_modules directory at the root of the Slate project.
  3. the flickity direcotry does not display.

More Information

For me, this has happened with two separate packages: Flickity and CartJS. This has happened within the same project but across two separate computers. More than happy to try and duplicate on a fresh theme install if that would better service this issue.

Currently using "@shopify/slate-tools": "0.13.0" version of Slate

patrickbjohnson commented 6 years ago

Seems like it may be related to the node_modules being ignored and not code editors (in this case VSCode) not updating the directory unless you reboot the IDE.

t-kelly commented 6 years ago

I've also seen this behaviour in VSCode. When in doubt, open the directory in Finder 😄

lock[bot] commented 6 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.