search

Shopify / slate

Slate is a toolkit for developing Shopify themes. It's designed to assist your workflow and speed up the process of developing, testing, and deploying themes.
https://shopify.github.io/slate
MIT License
1.28k stars 364 forks source link

Fix liquid styles not uploading to Shopify #883

Closed t-kelly closed 5 years ago

t-kelly commented 5 years ago

What are you trying to accomplish with this PR?

Fixes https://github.com/Shopify/slate/issues/864, followup #877

Had another look at this and found the source of the problem.. liquidStyle files are not being uploaded to Shopify servers because of some bad filtering on my end. Refining that filtering to exclude liquid styles will make sure its uploaded and you don't get a MIME type error.

Also can see the original scss.liquid file gets output into dist which might cause problems if uploaded to Shopify.

lock[bot] commented 5 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.