Shopify / slate

Slate is a toolkit for developing Shopify themes. It's designed to assist your workflow and speed up the process of developing, testing, and deploying themes.
https://shopify.github.io/slate
MIT License
1.28k stars 365 forks source link

Add new `slate-tools start --liveDeploy` flag to build and upload for testing #905

Open jonathanmoore opened 5 years ago

jonathanmoore commented 5 years ago

Problem

Currently, it is difficult to perform the final stages of testing and QA across multiple devices and platforms with the local server for CSS and JavaScript. For example, using tools like Google Lighthouse or relying on real-time QA by other remote team members involves the slow process of fully deploying and then re-checking issues.

The default slate-tools start combined with the local resource server has dramatically improved the rapid development process. Adding a new flag to bypass the local server and fully deploy would introduce a slight lag, but the tradeoff for testing and QA would be well worth the ability to work through final issues.

More Information

This new flag wouldn't be ideal for the bulk of development, but it would make life much easier during the final stages of theme testing and review.

Related #825, #710, #809, #759, #594

t-kelly commented 5 years ago

Thanks @jonathanmoore! Great issue as usual 👏

ezracelli commented 5 years ago

This would be a priceless feature! I'd be willing to author, do you have a good starting point on bypassing the asset server?

jonathanmoore commented 5 years ago

@ezracelli I'd love to see this push forward, and I'd be happy to provide feedback. However, with Slate's low-maintenance status I highly doubt anyone on the Shopify side would be able to review and add in a new feature of this size.

It's a bummer to feel stuck without actively maintained tools, but I'm hopeful Shopify will be able to dedicate resources again at some point.