search

Shopify / slate

Slate is a toolkit for developing Shopify themes. It's designed to assist your workflow and speed up the process of developing, testing, and deploying themes.
https://shopify.github.io/slate
MIT License
1.28k stars 364 forks source link

Graceful warning / reporting for `ECONNRESET` during yarn deploy #941

Closed justinmetros closed 5 years ago

justinmetros commented 5 years ago

Problem

Error ECONNRESET doesn't give very helpful feedback on what happened for production deployment.

Expected behavior is not having to guess if everything uploaded ok

Replication steps

yarn deploy ( slate-tools build && slate-tools deploy --env=production )

Happens 1/25 times maybe?

More Information

Error is: UnhandledPromiseRejectionWarning: Error: read ECONNRESET

↑  Uploading to Shopify...

[production]: 52 / 217 [==============>-----------------------------------------------------]  23 %
(node:18204) UnhandledPromiseRejectionWarning: Error: read ECONNRESET
    at TLSWrap.onStreamRead (internal/stream_base_commons.js:139:27)
(node:18204) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 2)
[production]: 217 / 217 [====================================================================] 100 %
dan-gamble commented 5 years ago

This is the same as https://github.com/Shopify/slate/issues/938

t-kelly commented 5 years ago

Closing in preference to #938. Thanks for the bug report!

lock[bot] commented 5 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.