search

Shopify / slate

Slate is a toolkit for developing Shopify themes. It's designed to assist your workflow and speed up the process of developing, testing, and deploying themes.
https://shopify.github.io/slate
MIT License
1.28k stars 364 forks source link

Event-stream not found 404 #946

Closed oscarteg closed 4 years ago

oscarteg commented 5 years ago

Problem

yarn create slate-theme my-new-theme gives a 404 error on the event-stream package.

~ ❯ yarn create slate-theme .
yarn create v1.13.0
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
error An unexpected error occurred: "https://registry.yarnpkg.com/event-stream/-/event-stream-3.3.6.tgz: Request failed \"404 Not Found\"".
info If you think this is a bug, please open a bug report with the information provided in "/Users/Example/.config/yarn/global/yarn-error.log".
info Visit https://yarnpkg.com/en/docs/cli/create for documentation about this command.
~ ❯

Replication steps

yarn create slate-theme my-new-theme

More Information

Maybe the version should be updated on the theme? I'm not sure where the package comes from.

oscarteg commented 5 years ago

The package was removed from NPM because it was stealing bitcoin...

https://blog.npmjs.org/post/180565383195/details-about-the-event-stream-incident

t-kelly commented 5 years ago

Just encountered and fixed this in Theme Scripts. Will follow through here as well. Thanks for the bug report @Oscarteg!

t-kelly commented 5 years ago

Hmm so in Theme Scripts we were referencing a particular version of event-stream, which I was able to fix by updating the yarn.lock file. I don't see any reference to event-stream in any other yarn.lock files.

cmincarelli commented 5 years ago

So, for anyone still running into this (as I just did), check your yarn-log and back track the dependency chain. I found out that the global install of nodemon.1.18.4 was the culprit in my case; it has nothing to do with this package.

nodemon@^1.18.4: pstree.remy@^1.1.0: ps-tree@^1.1.0: event-stream@~3.3.0: flatmap-stream "^0.1.0"

lock[bot] commented 4 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.