search

Shopify / slate

Slate is a toolkit for developing Shopify themes. It's designed to assist your workflow and speed up the process of developing, testing, and deploying themes.
https://shopify.github.io/slate
MIT License
1.28k stars 364 forks source link

Should not close the issues that didn't fix and Lock the conversation that currently active #952

Closed Uysim closed 5 years ago

Uysim commented 5 years ago

I just go through this repo. I see a lot of issues have been closed and conversation has been locked by bot while it is not address or fixed yet. Like currently I am facing the problem with jQuery is undefined I saw a lot of issues that have been closed with any fixing. Also the conversation is locked to prevent me from commenting event if it is inactive in the short time.

ghost commented 5 years ago

I agree about the auto lock thing.

With regards to your issue. If you are trying to use jQuery globally you may want to just do this:

import $ from 'jquery';

window.$ = $;
window.jQuery = $;

Generally not recommended to do it this way but is sometimes necessary as so many apps use jQuery.

t-kelly commented 5 years ago

Hey @Uysim -- we lock closed issues that have not been commented on in 30 days automatically to prevent users from pulling up old issues with potentially unrelated problems.

If you have a problem similar to one that is closed and locked, feel free to create a new issue and link to the one that is locked. That is a lot easier for us to manage!

Uysim commented 5 years ago

@george-dotdev that work like charm thank you

Uysim commented 5 years ago

@t-kelly I understand. This is just my opinion

lock[bot] commented 5 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.