search

Shopify / slate

Slate is a toolkit for developing Shopify themes. It's designed to assist your workflow and speed up the process of developing, testing, and deploying themes.
https://shopify.github.io/slate
MIT License
1.28k stars 364 forks source link

Wrong @babel/core version #959

Closed goldsteinr closed 5 years ago

goldsteinr commented 5 years ago

Problem

Seems like the slate-tools package needs an update with babel packages.

When running yarn,

warning "@shopify/slate-tools > stylelint-webpack-plugin@0.10.5" has incorrect peer dependency "stylelint@^8.0.0".

and when trying to build

Module build failed (from ../node_modules/babel-loader/lib/index.js):
Error: Requires Babel "^7.0.0-0", but was loaded with "6.26.3". If you are sure you have a compatible version of @babel/core, it is likely that something in your build process is loading the wrong version. Inspect the stack trace of this error to look for the first entry that doesn't mention "@babel/core" or "babel-core" to see what is calling Babel.

Replication steps

"@shopify/slate-tools": "1.0.0-beta.14",
"@babel/core": "7.2.2",
"babel-preset-shopify": "17.0.1"

My .babelrc

{
  "presets": ["babel-preset-shopify/web"]
}
goldsteinr commented 5 years ago

the problem seems to be with "babel-preset-shopify": "17.0.1".

installed "babel-preset-shopify": "^16.7.0", and works now.

macrozone commented 5 years ago

this is not really solved, as @shopify/slate-tools uses the old version of babel and should be upgraded to babel 7

lock[bot] commented 5 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.