search

Shopify / slate

Slate is a toolkit for developing Shopify themes. It's designed to assist your workflow and speed up the process of developing, testing, and deploying themes.
https://shopify.github.io/slate
MIT License
1.28k stars 364 forks source link

Yarn watch not updating existing files #960

Open bennybermudez opened 5 years ago

bennybermudez commented 5 years ago

Hi, I am having the following issue. When I save an existing file, Yarn watch returns the following message: (✔ Compiled successfully in 0.234s!), but the file is not being updated on the Shopify server. I have confirmed this in the edit code section of the theme. The oddity here is that if I create a new file and save, Yarn Watch pushes this new files to theme successfully.

t-kelly commented 5 years ago

Are you updating a JS or CSS file? They are hosted locally when using yarn start so they won't be uploaded to Shopify.

bennybermudez commented 5 years ago

Liquid files. Specifically an include in the snippets folder or a liquid file in the sections folder.

t-kelly commented 5 years ago

Having trouble reproducing this on my end. Could you please provide more details to reliably reproduce the bug you're encoutering?

Video of things working

dungle-scrubs commented 5 years ago

@bennybermudez I thought I was having the same problem for about an hour, but it turned out that after the "compiled successfully" message, when you see it uploading the file, the next terminal screen notified me of a liquid error so the file couldn't upload.

The problem for me was that my terminal window was short and I didn't think to scroll up to see the errors.

kasra-my commented 4 years ago

Hi @t-kelly my changes in JS files are not getting deployed when I run "yarn start/watch/deploy-dev". You said JS and CSS files are hosted locally so won't be uploaded to shopify, so how can I test and debug my javascript code? I already duplicated the active theme and have all the local settings in my config.yml file to test it locally, but it doesn't work :(