search

Shopify / slate

Slate is a toolkit for developing Shopify themes. It's designed to assist your workflow and speed up the process of developing, testing, and deploying themes.
https://shopify.github.io/slate
MIT License
1.28k stars 364 forks source link

Expose request timeout of themekit in .env #968

Closed Liroo closed 5 years ago

Liroo commented 5 years ago

This PR expose the request timeout optional setting of themekit in the .env of slate.

A .env at the root such as:

SLATE_STORE=***.myshopify.com
SLATE_PASSWORD=***
SLATE_THEME_ID=***
SLATE_IGNORE_FILES=config/settings_data.json
SLATE_TIMEOUT=2m

will set the timeout in config.yml at 2m SLATE_TIMEOUT used by themekit.

This closes #831, fixes #699 and maybe some others I didn't saw.

Checklist

For contributors:

For maintainers:

This is my first PR on Slate and maybe I'm not aware of everything in the project. I needed to modify the timeout for my own and saw some issues on this.

lock[bot] commented 5 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.