search

Shopify / slate

Slate is a toolkit for developing Shopify themes. It's designed to assist your workflow and speed up the process of developing, testing, and deploying themes.
https://shopify.github.io/slate
MIT License
1.28k stars 364 forks source link

Yarn deploy builds, but doesn't deploy #991

Open dungle-scrubs opened 5 years ago

dungle-scrubs commented 5 years ago

Problem

When I type yarn deploy, slate-tools build will successfully run, but I no longer receive the option to upload. Instead, I have to run yarn slate-tools deploy separately.

Cheers

victorjanin commented 5 years ago

@kevmon How does your package.json look like? the scripts part should be

"scripts": { "start": "slate-tools start", "watch": "slate-tools start --skipFirstDeploy", "build": "slate-tools build", "deploy": "slate-tools build && slate-tools deploy", "zip": "slate-tools build && slate-tools zip", "lint": "slate-tools lint", "format": "slate-tools format" }

dungle-scrubs commented 5 years ago

@peke314

Thanks, it looks exactly like that. I have two projects that are duplicates, it works for one but not the other. I'm not sure how to troubleshoot further.

dungle-scrubs commented 5 years ago

Update: It was a plugin that was causing this issue - called BundleAnalyzerPlugin - when extending webpack in slate.config.js.

nboliver commented 4 years ago

@dungle-scrubs - This helped me, thanks.