Shopify / spoom

Useful tools for Sorbet enthusiasts
MIT License
224 stars 19 forks source link

Problem with `Gemfile.lock` #529

Closed andyw8 closed 8 months ago

andyw8 commented 8 months ago

Running bundle locally on main is causing changes to Gemfile.lock:

spoom main % g diff
diff --git a/Gemfile.lock b/Gemfile.lock
index d0a6850..2cf1a68 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -40,8 +40,8 @@ GEM
     racc (1.7.3)
     rainbow (3.1.1)
     rake (13.1.0)
-    rbi (0.1.6)
-      prism (>= 0.18.0, < 0.20)
+    rbi (0.1.9)
+      prism (>= 0.18.0, < 0.25)
       sorbet-runtime (>= 0.5.9204)
     rdoc (6.6.2)
       psych (>= 4.0.0)
@@ -71,7 +71,6 @@ GEM
       sorbet-static (= 0.5.11287)
     sorbet-runtime (0.5.11287)
     sorbet-static (0.5.11287-universal-darwin)
-    sorbet-static (0.5.11287-x86_64-linux)
     sorbet-static-and-runtime (0.5.11287)
       sorbet (= 0.5.11287)
       sorbet-runtime (= 0.5.11287)
@@ -93,10 +92,7 @@ GEM
       yard (>= 0.9)

 PLATFORMS
-  arm64-darwin-21
   arm64-darwin-23
-  universal-darwin-22
-  x86_64-linux

 DEPENDENCIES
   bundler (>= 2.2.10)
andyw8 commented 8 months ago

If we check out the second-newest commit on main, 614084b54bc7b4bbaef8743b5620055d1fa9c3a5, bundle runs fine without changing to Gemfile.lock. So f529cdcab2a8c4e585ffe1a4e24fe850b260db4c is to blame.

andyw8 commented 8 months ago

~The problem seems to begin with rbi 0.1.8, it's fine with 0.1.7.~

andyw8 commented 8 months ago

There must be a bug in Bundler, try this on main:

egiurleo commented 8 months ago

Opened an issue on bundler: https://github.com/rubygems/rubygems/issues/7536

andyw8 commented 8 months ago

https://github.com/Shopify/spoom/pull/528 got auto-closed because https://github.com/Shopify/spoom/pull/534 was opened, and it seems to no longer have the PLATFORMS problem. 🤔

andyw8 commented 8 months ago

I'll close this since it seems to have resolved itself.

egiurleo commented 8 months ago

Should I close the bundler issue since this is no longer reproducible?

andyw8 commented 8 months ago

Yeah, let's close and we can re-open if it happens again.