Closed bouk closed 8 years ago
@lemonmade I've added some fixes to make commoner a bit more robust, you can read the 3 commits for details. I don't expect there to be any more caching issues as long as people bump the asset version when they change the config.
I also bumped the schmooze version as it contained an issue where it would clobber certain instance variables (like @env, which Processor uses) -> https://github.com/Shopify/schmooze/commit/c4a5d35239b9214ff0f4a10471959c17dabb0d02
@env
Just a few small questions from me, looks good 👍
@lemonmade I've added some fixes to make commoner a bit more robust, you can read the 3 commits for details. I don't expect there to be any more caching issues as long as people bump the asset version when they change the config.
I also bumped the schmooze version as it contained an issue where it would clobber certain instance variables (like
@env
, which Processor uses) -> https://github.com/Shopify/schmooze/commit/c4a5d35239b9214ff0f4a10471959c17dabb0d02