search

Shopify / sprockets-commoner

Use Babel in Sprockets to compile JavaScript modules for the browser
MIT License
182 stars 22 forks source link

Don't use the babel version in the cache key #27

Closed bouk closed 8 years ago

bouk commented 8 years ago

This prevents a node.js process being started if we need the cache key, but don't actually transform anything. We don't really need the babel version in the cache key, unless there's been a major bump but then the user should just wipe the cache or something.

@sirupsen

sirupsen commented 8 years ago

I have pretty much no context on this. Can someone else with more knowledge on Sprockets jump in here instead? Otherwise I don't feel comfortable signing off on this. I can try to learn if such a person doesn't exist.

unless there's been a major bump but then the user should just wipe the cache or something.

Can we just include the major part of the version to make this automatic?

rafaelfranca commented 8 years ago

unless there's been a major bump but then the user should just wipe the cache or something.

Disagree. The users should not have to know about this. Even more if users means 400 people.

bouk commented 8 years ago

OK I just realized that there's a way to do this without running JS, sorry for pulling the trigger so early. We can get the version from the package's package.json without spinning up a node.js process. I'll make a PR that does that instead

rafaelfranca commented 8 years ago

:+1: