Shopify / sprockets-commoner

Use Babel in Sprockets to compile JavaScript modules for the browser
MIT License
182 stars 22 forks source link

Add node-libs-browser as default dependency #31

Closed xfalcox closed 1 year ago

xfalcox commented 8 years ago

First of all thanks!!! This is the third time a shopify lib saves me!

Putting together a a build here, I was getting a lot of errors because people assume that the node core libs are loaded, as most people use Browserify or Webpack.

Maybe add a hint on the readme or just adopt a bundle like node-libs-browser and make it avaliable as default?

bouk commented 8 years ago

Hi, I actually have a working version of this on a PR here https://github.com/Shopify/sprockets-commoner/pull/21, but I haven't taken the time yet to finish it