Shopify / sprockets-commoner

Use Babel in Sprockets to compile JavaScript modules for the browser
MIT License
182 stars 22 forks source link

Remove protection against defining a variable that's a package identifier #41

Closed bouk closed 7 years ago

bouk commented 7 years ago

It caused issues when the same variable was using for requires multiple times, which caused the binding to be removed by one of the requires. There was protection against someone defining a variable that was a commoner package identifier, but that isn't really needed.

@tessalt

Fixes #40

tedtate commented 7 years ago

Awesome. 👍

tessalt commented 7 years ago

👍