search

Shopify / statsd-instrument

A StatsD client for Ruby apps. Provides metaprogramming methods to inject StatsD instrumentation into your code.
http://shopify.github.io/statsd-instrument
MIT License
574 stars 97 forks source link

Update CHANGELOG.md #156

Closed joeyfreund closed 5 years ago

joeyfreund commented 5 years ago

I was reviewing a PR that upgrades statsd-instrument from 2.3.2 to 2.3.4 and failed CI due to

undefined method `duration' for StatsD::Instrument:Module

I wanted to make sure that the CHANGELOG accurately reflects breaking changes

wvanbergen commented 5 years ago

That was not intentional

joeyfreund commented 5 years ago

That was not intentional

Then I'm happy I reported it.
Please let me know if there is anything else I can do to help.

For reference, this is how I got rid of our CI error.

wvanbergen commented 5 years ago

Apparently I cannot revert the PR that removed it anymore. If you could open a PR that re-adds this method, we can cut a new release.

joeyfreund commented 5 years ago

👍I'll try to make some time for it today.

For (my own) reference, this is the relevant commit:

image

wvanbergen commented 5 years ago

Closing this PR, because we are re-adding this method.