search

Shopify / statsd-instrument

A StatsD client for Ruby apps. Provides metaprogramming methods to inject StatsD instrumentation into your code.
http://shopify.github.io/statsd-instrument
MIT License
574 stars 97 forks source link

Added cloudwatch instrument support #160

Closed jponc closed 5 years ago

jponc commented 5 years ago

Description

Add support for cloudwatch instrument. Cloudwatch now accepts statsd protocol. It also has the ability to add tags

TODO

Updated README to include cloudwatch

wvanbergen commented 5 years ago

Hello @jponc!

Thank you for your contribution. We are currently in the process of doing a major release that completely changes the way we support different implementations. The CHANGELOG contains more information about the next major version.

We will not be accepting PRs that add support for other implementations on the legacy implementation as a result. Instead, to support Cloudwatch in the new StatsD::Instrument::Client implementation, you'll have to implement a subclass of the DatagramBuilder class.

jponc commented 5 years ago

Hi @wvanbergen ,

Yeah I'll probably wait for you guys finalise the major release and probably work on top of that. I'll close this PR for the meantime.

Cheers, Julian