Shopify / statsd-instrument

A StatsD client for Ruby apps. Provides metaprogramming methods to inject StatsD instrumentation into your code.
http://shopify.github.io/statsd-instrument
MIT License
570 stars 94 forks source link

Deprecate setting prefix on metric calls #206

Closed wvanbergen closed 4 years ago

wvanbergen commented 4 years ago

I've modified strict mode to blow up when these keyword arguments are used. Testing that on the Shopify codebase now.

casperisfine commented 4 years ago

Ultimately different prefix should be different clients.

That or go redis-namespace style.

wvanbergen commented 4 years ago

Ultimately different prefix should be different clients.

That's the plan with the new client:

prefixed_client = StatsD.client.with_prefix('foo')
prefixed_client.increment('bar')