search

Shopify / statsd-instrument

A StatsD client for Ruby apps. Provides metaprogramming methods to inject StatsD instrumentation into your code.
http://shopify.github.io/statsd-instrument
MIT License
574 stars 97 forks source link

New client: add support for `no_prefix: true` when emitting metrics. #209

Closed wvanbergen closed 5 years ago

wvanbergen commented 5 years ago

I am not a big fan of the no_prefix keyword argument. With the new client, it's easy to instantiate another client based on the current client with a different prefix, and use this separate client to emit your metrics.

However, I don’t think we can deprecate it with the new client. Specifically some libraries depend on this, and they may have to support statsd-instrument v2 and v3 simultaneously during the upgrade period. So I think we'll have to support this option.