Shopify / statsd-instrument

A StatsD client for Ruby apps. Provides metaprogramming methods to inject StatsD instrumentation into your code.
http://shopify.github.io/statsd-instrument
MIT License
574 stars 97 forks source link

Remove Expectation#ignore_tags #232

Closed wvanbergen closed 5 years ago

wvanbergen commented 5 years ago

We should remove support for ignore_tags when defining StatsD expectations. It doesn't do what you think it does: by default, assert_statsd_* already ignores any unspecified tags.

Expectation#ignore_tags was added in https://github.com/Shopify/statsd-instrument/pull/62. It served a need we had in our codebase at some point of time, but we no longer need it. None of our other codebases are using this feature. Given that this feature was never documented, I think we can remove this without a deprecation cycle.