search

Shopify / statsd-instrument

A StatsD client for Ruby apps. Provides metaprogramming methods to inject StatsD instrumentation into your code.
http://shopify.github.io/statsd-instrument
MIT License
570 stars 94 forks source link

Fix lots of typos #236

Closed sambostock closed 4 years ago

sambostock commented 4 years ago

This fixes most (if not all) typos in the codebase.

I found them using the scspell tool by running

git ls-files | xargs -o scspell

and dealing with each unknown word, one by one. 😅

Most of the typos were in text files, or in comments. A couple were actual code (e.g. variable names), but those should have had every occurrence replaced.

sambostock commented 4 years ago

The test suite appears to be failing on Windows because of

Run gem install bundler && bundle install --jobs 4 --retry 3
At D:\a\_temp\48aedf55-2f9e-41d7-893b-70269dfa3633.ps1:2 char:21
+ gem install bundler && bundle install --jobs 4 --retry 3
+                     ~~
The token '&&' is not a valid statement separator in this version.
+ CategoryInfo          : ParserError: (:) [], ParseException
+ FullyQualifiedErrorId : InvalidEndOfLine

which seems unrelated. I tried reverting my commit, and it still fails.

I also noticed that after resetting back to my original commit and force pushing, it ran GitHub ran the workflows against the commit again, so there are now duplicates, which I assume is a bug in GitHub workflows.

HereComeTheWalrus is also having a hard time with this page, and constantly refreshing, though I'm not sure if that's related, or just my machine being messed up 😅

wvanbergen commented 4 years ago

Yeah, I am not sure why that started failing. If you want to, can you spin up a PR to disable this?