Disable Windows CI check

Shopify / statsd-instrument

A StatsD client for Ruby apps. Provides metaprogramming methods to inject StatsD instrumentation into your code.

http://shopify.github.io/statsd-instrument

MIT License

570 stars 94 forks source link

Disable Windows CI check #238

Closed sambostock closed 4 years ago

sambostock commented 4 years ago

This disables the CI check against Windows, as per @wvanbergen's comment on #236.

For some reason, the Windows check started failing with the following error.

Run gem install bundler && bundle install --jobs 4 --retry 3
At D:\a\_temp\48aedf55-2f9e-41d7-893b-70269dfa3633.ps1:2 char:21
+ gem install bundler && bundle install --jobs 4 --retry 3
+                     ~~
The token '&&' is not a valid statement separator in this version.
+ CategoryInfo          : ParserError: (:) [], ParseException
+ FullyQualifiedErrorId : InvalidEndOfLine

Temporarily excluding Windows unblocks CI for other PRs until this is figured out.

Closes #239

sambostock commented 4 years ago

I may have just found a bug in GitHub Actions?

I originally tried

exclude:
  - platform: windows-2019
  # ...

But it looks like you need to exclude specific combinations, so I changed it to

exclude:
  - platform: windows-2019
    ruby: 2.6
  # ...

Looks like now the check list expects Ruby 2.6 on windows-2019, because of my first commit, but it will never run cause my second commit excludes it. 🤔

sambostock commented 4 years ago

Still not working. Tried opening #238 as a new PR, but that didn't work either. Any ideas @wvanbergen? Is there somewhere where that check is configured as required? Is GitHub Actions using the config from master instead of this branch?

wvanbergen commented 4 years ago

I had to update branch protection rules.