search

Shopify / statsd-instrument

A StatsD client for Ruby apps. Provides metaprogramming methods to inject StatsD instrumentation into your code.
http://shopify.github.io/statsd-instrument
MIT License
570 stars 94 forks source link

Remove dependency on StatsD::Instrument::Metric in Expectation. #241

Closed wvanbergen closed 4 years ago

wvanbergen commented 4 years ago

In the next major version StatsD::Instrument::Metric will be removed. So we should not depend on it.

In an ideal world, we should call normalize_tags on the datagram builder of the client on which we want to run the expectation, so people can use different implementations.That's something I will leave for a future PR.