search

Shopify / statsd-instrument

A StatsD client for Ruby apps. Provides metaprogramming methods to inject StatsD instrumentation into your code.
http://shopify.github.io/statsd-instrument
MIT License
574 stars 97 forks source link

Lazy-evaluate StatsD.singleton_client when no client is defined on a metaprogramming method call #244

Closed wvanbergen closed 5 years ago

wvanbergen commented 5 years ago

This ensures that we pick up when the singleton client changes, to ensure backwards compatible behaviour.

With the legacy client, this was not an issue because you would always make in-place config changes on the only LegacyClient instance. With the new client, you would have to instantiate a complete new client, and assign it to StatsD.singleton_client. Those reassignments would be lost for metaprogramming methods before, if they would happen after the metaprogaramming method was evaluated.