Shopify / statsd-instrument

A StatsD client for Ruby apps. Provides metaprogramming methods to inject StatsD instrumentation into your code.
http://shopify.github.io/statsd-instrument
MIT License
574 stars 97 forks source link

Make void a regular but frozen object, rather than a basic object #247

Closed wvanbergen closed 5 years ago

wvanbergen commented 5 years ago

Using a BasicObject for VOID return values is a bit too restrictive. Many things that work on object are not supported (e.g. #tap and #class), which breaks all kinds of instrumentation wrapper methods. Technically that means that those methods depend on the return value of a StatsD metric and should be fixed, but it creates a bit too much pain.