Shopify / statsd-instrument

A StatsD client for Ruby apps. Provides metaprogramming methods to inject StatsD instrumentation into your code.
http://shopify.github.io/statsd-instrument
MIT License
570 stars 94 forks source link

Allow positional value arguments for assert_statsd_ calls #249

Closed wvanbergen closed 4 years ago

wvanbergen commented 4 years ago

Allow a positional value arguments for assert_statsd_* calls, rather than a keyword argument. Also for StatsD::Instrument::Expectation builder methods. This is to be in line with the corresponding StatsD.metric calls that also take a positional argument for value.

E.g., you can now do assert_statsd_increment(‘metric’, 10) rather than assert_statsd_increment(‘metric’, value: 10)

The old value keyword argument is still supported, and takes priority if present.