search

Shopify / statsd-instrument

A StatsD client for Ruby apps. Provides metaprogramming methods to inject StatsD instrumentation into your code.
http://shopify.github.io/statsd-instrument
MIT License
570 stars 94 forks source link

Rubocop improvements #260

Closed wvanbergen closed 4 years ago

wvanbergen commented 4 years ago

Best reviewed with whitespace diff turned on: https://github.com/Shopify/statsd-instrument/pull/260/files?w=1

rafaelfranca commented 4 years ago

I think we should change the way this project inherit the styleguide from the URL to the gem.

you can add this to your Gemfile:

gem 'rubocop-shopify', require: false

And add to the top of your project's RuboCop configuration file:

inherit_gem:
  rubocop-shopify: rubocop.yml

Instead of the inherit_from. You can also delete the cache file after that.

wvanbergen commented 4 years ago

@rafaelfranca updated