Enable UDP batching by default

Shopify / statsd-instrument

A StatsD client for Ruby apps. Provides metaprogramming methods to inject StatsD instrumentation into your code.

http://shopify.github.io/statsd-instrument

MIT License

574 stars 97 forks source link

Enable UDP batching by default #281

Closed casperisfine closed 3 years ago

casperisfine commented 3 years ago

So we deployed https://github.com/Shopify/statsd-instrument/pull/280 in production and the result are very good, and we didn't notice any issue.

Given the perf improvement, and that it no longer need an after_fork callback, I think we should enable it by default so that people get the perf improvement simply by updating.

@wvanbergen @dylanahsmith thoughts?

wvanbergen commented 3 years ago

We should do a minor new version release after merging this.
Does it make sense to keep the old UDP sink? Or can we replace the old implementation with the new one?

casperisfine commented 3 years ago

Does it make sense to keep the old UDP sink? Or can we replace the old implementation with the new one?

I think it does still make sense yes. It would be a bit hard to have the Batched sink handle a 0.0 interval.

We should do a minor new version release after merging this.

Yes, 3.1.0 is good for you?

wvanbergen commented 3 years ago

Yes, 3.1.0 is good for you?

:+1: