Shopify / statsd-instrument

A StatsD client for Ruby apps. Provides metaprogramming methods to inject StatsD instrumentation into your code.
http://shopify.github.io/statsd-instrument
MIT License
570 stars 94 forks source link

Tests that relied on tags being matcher are broken #335

Closed pedro-stanaka closed 1 year ago

pedro-stanaka commented 1 year ago

Summary

In #331 we introduced some changes that fail tests that rely on using the tags option for the Statsd assertion as a RSpec matcher. If the test would use a matcher like this:

expect do
      my_tested_function()
    end.to(trigger_statsd_distribution("time_took_ms", tags: include(
      "foo:true",
      "bar:invalid",
    )))

The test would fail because include matcher does not answer to empty?.