search

Shopify / statsd-instrument

A StatsD client for Ruby apps. Provides metaprogramming methods to inject StatsD instrumentation into your code.
http://shopify.github.io/statsd-instrument
MIT License
570 stars 94 forks source link

Fix support to rubocop autocorrect #346

Closed rafaelzimmermann closed 1 year ago

rafaelzimmermann commented 1 year ago

Fix: https://github.com/Shopify/statsd-instrument/pull/303

RuboCop introduced some breaking changes on v1, and this addresses the changes to fix autocorrect. https://docs.rubocop.org/rubocop/v1_upgrade_notes.html

casperisfine commented 1 year ago

Can you fix the remaining rubocop issue?

rafaelzimmermann commented 1 year ago

Can you fix the remaining rubocop issue?

I will try to open some space to work on it today 🤞

rafaelzimmermann commented 1 year ago

The PR looks big, but the second commit is just code style adjustment to meet rubocop-shopify upgrade