search

Shopify / statsd-instrument

A StatsD client for Ruby apps. Provides metaprogramming methods to inject StatsD instrumentation into your code.
http://shopify.github.io/statsd-instrument
MIT License
574 stars 97 forks source link

Allow `nil` in `clone_with_options` #351

Closed Mangara closed 1 year ago

Mangara commented 1 year ago

Fixes https://github.com/Shopify/statsd-instrument/issues/350

This is a first stab at allowing nil to override existing values in clone_with_options. My biggest concern is that this is technically a breaking change, although the documentation seems to imply that this behaviour is how it's supposed to work.