search

Shopify / tapioca

The swiss army knife of RBI generation
MIT License
746 stars 128 forks source link

v0.11.9 - All controller RBIs deleted #1658

Closed alex-tan closed 1 year ago

alex-tan commented 1 year ago

This includes Devise, ActiveAdmin in sorbet/rbi/dsl and rbis for controllers in our app/ directory after running tapioca dsl.

Rails: 7.0.7 Ruby: 3.2.2

This is after upgrading from 0.11.8 on two projects. Any reason this would be expected behavior?

Morriar commented 1 year ago

Hey @alex-tan,

Since https://github.com/Shopify/tapioca/pull/1611, most of the content for controllers have been move back to the super class which means a lot of the previously generated files are now useless.

Do you get any new type errors related to this change?

alex-tan commented 1 year ago

Ah ok good to know. The only ones I saw were because we had controllers that inherited from Devise controllers and those classes are no longer in the RBIs, however if that's the direction it's easy enough for us to add shims for them.

Morriar commented 1 year ago

The only ones I saw were because we had controllers that inherited from Devise controllers and those classes are no longer in the RBIs

This may be a regression though. Do you mind opening another issue with an example please? 🙏

alex-tan commented 1 year ago

@Morriar Are you looking for something like a minimal reproducible example?

Morriar commented 1 year ago

Ideally, yes. Thanks!