search

Shopify / tapioca

The swiss army knife of RBI generation
MIT License
701 stars 115 forks source link

Protobuf generated classes should extend from `Google::Protobuf::AbstractMessage` #1911

Closed andyw8 closed 1 month ago

andyw8 commented 1 month ago

Motivation

Problem reported in Shopify Core that to_proto wasn't being recognized.

Implementation

~Mix in the necessary module.~ Inherit from Google::Protobuf::AbstractMessage.

Tests

Updated.

andyw8 commented 1 month ago

Updated with @Morriar's suggestion, but looking into the 1 failing test.

andyw8 commented 1 month ago

Passing on Core.

andyw8 commented 1 month ago

(merging this commit history was unintentional, I was used to the auto-squash in other repos).