Shopify / theme-check-action

Run shopify/theme-check on GitHub pull requests
Other
37 stars 14 forks source link

Update to actions/checkout@v3 for Node 16 Compatibility #29

Closed snacsnoc closed 8 months ago

snacsnoc commented 8 months ago

This PR updates the GitHub Actions workflow and README documentation to use actions/checkout@v3. This change is necessary to ensure compatibility with the latest GitHub Actions runner environment, which now defaults to Node.js version 16. The change is in response to the deprecation of Node.js 12 and GitHub's move to enforce Node.js 16 in all workflows.

Warning produced by continue using actions/checkout@v2 in the GHA:

Theme Check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Background:

As of June 13, 2023, GitHub announced the deprecation of Node.js 12, which has been out of support since April 2022. In compliance with this, all actions are required to run on Node.js 16. Notice from Github: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Testing: GHA now use Node 16 by default unless specified with ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. I've tested this change on a repo of ours and it works as expected, screenshot displaying exit code 0.

Screenshot 2024-01-05 at 03 25 09