search

Shopify / theme-check-action

Run shopify/theme-check on GitHub pull requests
Other
37 stars 14 forks source link

Feature Request: Add annotations #4

Closed sergeh closed 2 years ago

sergeh commented 3 years ago

Could annotations be added to the status checks? It would be nice to see the lint errors directly on the files.

Here's an example with stylelint image

charlespwd commented 3 years ago

🤩 this would be awesome! TIL.

https://docs.github.com/en/rest/reference/checks

Notes

I think this would be easier to do if we did https://github.com/Shopify/theme-check/issues/220

And we could leave the GitHub integration in this codebase by parsing the test results and then annotating the PR with the GitHub action's GITHUB_TOKEN.

charlespwd commented 2 years ago

Fixed in latest release :)