Theme check failing on comments in JSON file....added by Shopify

Shopify / theme-check-action

Run shopify/theme-check on GitHub pull requests

Other

37 stars 14 forks source link

Theme check failing on comments in JSON file....added by Shopify #45

Closed jlbruno closed 1 week ago

jlbruno commented 2 months ago

Describe the bug Theme check is returning an error on a JSON file because it has a comment block in it...that looks like it was added by Shopify.

Expected Theme check shouldn't error on anything that's being added by Shopify

Actual Theme check throws an error on comments in JSON file.

Stack trace

Debugging information

Github action using shopify/theme-check-action@v2
Also fails on local terminal using shopify CLI version 3.62.0

lukeh-shopify commented 1 month ago

Hi @jlbruno, I've moved this to the appropriate repository. I believe we have released changes that should have resolved your issue. Are you able to confirm this is still a problem? Thank you!

joshmlamb commented 2 weeks ago

Hi @lukeh-shopify

I was also experiencing this issue but updating to the latest version of the CLI resolved this issue. Thank you!

lukeh-shopify commented 1 week ago

👋 Thanks for confirming @joshmlamb!

@jlbruno, do you have the Shopify CLI version pinned in your workflow configuration by any chance? Excluding the version parameter will default to using the latest Shopify CLI, which should resolve the issue. Let me know if you have any trouble still

Cheers

lukeh-shopify commented 1 week ago

👋🏻 Hey @jlbruno, because there hasn’t been activity in the last couple of weeks we’ll be closing this issue. However if you’re still experiencing the same problem, please reopen the issue and share the outstanding context we’ve requested. Thanks!