search

Shopify / theme-check

The Ultimate Shopify Theme Linter
Other
339 stars 96 forks source link

Remote Asset – .mp4 video URL #496

Closed bigskillet closed 2 years ago

bigskillet commented 2 years ago

I'm getting a RemoteAsset warning even though the file is being served by the Shopify CDN. For example, the file has been uploaded in Settings > Files, and the URL to that file is being inserted into the text field video_url:

<video autoplay muted loop playsinline>
  <source src="{{ section.settings.video_url }}" type="video/mp4">
</video>
charlespwd commented 2 years ago

Thanks for reporting! A bug indeed.

In the meantime, you can disable the rule in that file with the magic comment (really wish the new comment syntax could land).

{% comment %}theme-check-disable RemoteAsset{% endcomment %}