Add support for `#` inline comment tag

Shopify / theme-check

The Ultimate Shopify Theme Linter

Other

337 stars 95 forks source link

Closed charlespwd closed 2 years ago

charlespwd commented 2 years ago

The # inline comment tag is coming. This PR adds support for it in theme-check.

Looking forward to using this :+1::

{% # theme-check-disable ParserBlockingJavaScript %}

Instead of this :-1: :

{% comment %}theme-check-disable ParserBlockingJavaScript{% endcomment %}

Currently blocked until Shopify/liquid#1498 is merged and we have a new Liquid release.

ConduciveMammal commented 2 years ago

@charlespwd this seems to have been pushed live now. Seems to work fine on my stores

charlespwd commented 2 years ago

Hmm. Should probably bug them. It's still "unreleased" even though we use it in prod.

blanklob commented 2 years ago

I still have the issue.