Shopify / theme-check

The Ultimate Shopify Theme Linter
Other
337 stars 95 forks source link

theme-check crashing out on file check #545

Closed ConduciveMammal closed 2 years ago

ConduciveMammal commented 2 years ago

Seems to be hanging up on a certain img tag. The file itself is generated by PageFly so I can't be certain on it's usage.

/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/bug.rb:20:in `bug'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_node.rb:152:in `rescue in parseable_markup'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_node.rb:142:in `parseable_markup'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_node.rb:97:in `markup'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/checks.rb:51:in `rescue in call_check_method'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/checks.rb:29:in `call_check_method'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/checks.rb:11:in `block in call'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/checks.rb:10:in `each'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/checks.rb:10:in `call'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:32:in `call_checks'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:23:in `visit'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:24:in `block in visit'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:24:in `each'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:24:in `visit'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:24:in `block in visit'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:24:in `each'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:24:in `visit'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:24:in `block in visit'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:24:in `each'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:24:in `visit'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:24:in `block in visit'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:24:in `each'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:24:in `visit'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:24:in `block in visit'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:24:in `each'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:24:in `visit'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:24:in `block in visit'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:24:in `each'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:24:in `visit'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:24:in `block in visit'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:24:in `each'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:24:in `visit'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:24:in `block in visit'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:24:in `each'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:24:in `visit'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:24:in `block in visit'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:24:in `each'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:24:in `visit'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:24:in `block in visit'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:24:in `each'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:24:in `visit'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:24:in `block in visit'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:24:in `each'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:24:in `visit'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:24:in `block in visit'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:24:in `each'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:24:in `visit'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:24:in `block in visit'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:24:in `each'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:24:in `visit'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:24:in `block in visit'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:24:in `each'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:24:in `visit'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:24:in `block in visit'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:24:in `each'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:24:in `visit'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:24:in `block in visit'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:24:in `each'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:24:in `visit'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:24:in `block in visit'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:24:in `each'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:24:in `visit'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:24:in `block in visit'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:24:in `each'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:24:in `visit'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:24:in `block in visit'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:24:in `each'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:24:in `visit'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:24:in `block in visit'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:24:in `each'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:24:in `visit'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/html_visitor.rb:14:in `visit_liquid_file'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/analyzer.rb:54:in `block (2 levels) in analyze_theme'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/analyzer.rb:51:in `each'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/analyzer.rb:51:in `each_with_index'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/analyzer.rb:51:in `block in analyze_theme'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check.rb:68:in `with_liquid_c_disabled'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/analyzer.rb:50:in `analyze_theme'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/language_server/diagnostics_engine.rb:34:in `block in analyze_and_send_offenses'
/usr/local/Cellar/ruby/3.0.3/lib/ruby/3.0.0/benchmark.rb:293:in `measure'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/language_server/diagnostics_engine.rb:33:in `analyze_and_send_offenses'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/language_server/handler.rb:193:in `analyze_and_send_offenses'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/language_server/handler.rb:82:in `on_text_document_did_open'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/language_server/server.rb:110:in `handle_message'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/language_server/server.rb:80:in `block (3 levels) in start_handler_threads'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/language_server/server.rb:77:in `loop'
/usr/local/Cellar/theme-check/1.9.2/gems/theme-check-1.9.2/lib/theme_check/language_server/server.rb:77:in `block (2 levels) in start_handler_threads'
[Info  - 9:19:46 AM] Connection to server got closed. Server will restart.
Checking /Users/liammerlyn/Shopify.nosync/TechOutlet/src/theme
ThemeCheck::ThemeCheckError: Can't find a parseable tag of name img inside the parseable HTML.

Tag name:
  "img"

File:
  sections/pf-cacd6cac.liquid

Line number:
  61

Excerpt:

["\t\t\t\twindow.pageflyProducts = window.pageflyProducts || {};\n", "\t\t\t\twindow.__pageflyProducts[\"≬2n##########≬\"] = {\n", "\t\t\t\t\tid: ≬2o##################≬,\n", "\t\t\t\t\thandle: ≬2p######################≬,\n", "\t\t\t\t\ttitle: ≬2q#####################≬,\n", "\t\t\t\t\ttype: ≬2r####################≬,\n"]

Theme Check Version: 1.9.2
Ruby Version: 3.0.3
Platform: x86_64-darwin21
Muffin mode: activated

The particular line of code it's crashing at is:

<div class="sc-cVAmsi fCHPvN pf-26_ {{pf_all}} {{pf_laptop}} {{pf_tablet}} {{pf_mobile}}" data-img-id="{{ image.id }}" data-pf-type="ImageItem"><img loading="eager" src="{{ image.src | img_url: "master" }}" alt="{{ image.alt }}" draggable="false"/></div>{% endfor %}</div>{% if true %}<div data-pf-nav="prev" class="sc-ewSTlh cKhGuf"><i class="pfa pfa-angle-left"></i></div><div data-pf-nav="next" class="sc-ewSTlh cKhGuf"><i class="pfa pfa-angle-right"></i></div>{% endif %}</div></div></div><h3 data-product-type="title" data-product-id="{{ product.id }}" data-pf-type="ProductTitle" class="sc-jvvksu bwdWwO pf-28_">{{ product.title }}</h3><div data-pf-type="Block" class="sc-bTfYFJ bjbLhm pf-29_"><div data-product-type="price" data-product-id="{{ product.id }}" data-product-price="true" data-pf-type="ProductPrice" class="sc-jivBlf fhupZU pf-30_">{{ product.variants[0].price | money }}</div><div data-product-type="compare_at_price" data-product-id="{{ product.id }}" data-pf-type="ProductPrice" class="sc-jivBlf fhupZU pf-31_">{{ product.variants[0].compare_at_price | money }}</div></div><a class="sc-cvlWTT fNzoqU pf-32_" data-product-id="{{ product.id }}" href="{{ product.url | within: collection }}" data-pf-type="ProductViewDetails"><span>View Details</span></a></div></div></div>{% endform %}{% endif %}</div><script>