Shopify / theme-check

The Ultimate Shopify Theme Linter

Other

337 stars 95 forks source link

Closed kilgore5 closed 2 years ago

kilgore5 commented 2 years ago

Potential fix for #564

Basic issue

I'm running theme check for a root dist and trying to require a custom check that lives outside the dist folder

The spec I wrote doesn't break either way, I believe because when run from command line like shopify theme check --config .config/.theme-check.yml then ThemeCheck::Config.load_config gets a relative path passed in and I'm not 100% sure how to simulate that with the spec

charlespwd commented 2 years ago

Manually tested & confirmed!

kilgore5 commented 2 years ago

@charlespwd much belated thanks for the quick merge!