search

Shopify / theme-check

The Ultimate Shopify Theme Linter
Other
337 stars 95 forks source link

Support app drop in theme app extensions #566

Closed veken1199 closed 2 years ago

veken1199 commented 2 years ago

Context

We would like to support App Liquid drop in theme app extension Liquid code such as app blocks and embeds.

How did we implement this change?

We updated the initializer of UndefinedObject checker to take a new arg called config_type which is set to :default as the default value. We updated then theme app extension config file to pass the config_type of UndefinedObject checker as :theme_app_extension. Base on theconfig_type` we will be able to allow and reject more liquid objects in theme app extension liquid code.

edo888 commented 1 year ago

Hi,

Could someone respond to this: https://community.shopify.com/c/online-store-2-0/accessing-app-owned-metafields-from-theme-extension-block-liquid/m-p/1879073 ?

Thanks!