search

Shopify / theme-check

The Ultimate Shopify Theme Linter
Other
337 stars 95 forks source link

theme-check with onlySingleFileChecks reports fixed "full check" errors #570

Closed vfonic closed 2 years ago

vfonic commented 2 years ago

Related: theme-check reports "full theme check" errors on removed files Shopify/theme-check#569

Repro steps:

  1. Open VS Code settings JSON and set: "themeCheck.onlySingleFileChecks": true,
  2. Open theme.liquid (this is the easiest)
  3. Add {{ 'unknown_variable' | t }} right below <head> (anywhere really, but my screenshots show this location)
  4. Run: >Liquid Theme Check: Run Checks
  5. See the error was created: Screen Shot 2022-02-26 at 12 11 37
  6. Delete the whole line of code that added the error.

Expected:

The error goes away

Actual:

The error underline stays at the same place where the error was before deletion.

Screen Shot 2022-02-26 at 12 11 46

The error goes away when running >Liquid Theme Check: Run Checks again.