search

Shopify / theme-check

The Ultimate Shopify Theme Linter
Other
337 stars 95 forks source link

"AppBlockValidTags" not working as expected #581

Closed octipus closed 2 years ago

octipus commented 2 years ago

Hi all!

Unless i get this wrong, the check should only be fired on the App Extension Blocks. However, it seems it is fired globally on any .liquid file. Below is an example where this is griggered on the the liquid file.

Screenshot 2022-05-13 3 51 54 PM

charlespwd commented 2 years ago

Hey @octipus, the AppBlockValidTags is a check for Theme app extensions. layout/theme.liquid is a file typically used for themes and not apps. So is it simply that this check is enabled when it shouldn't be?

The default config has this set to enabled: false. It's safe to do for themes.