Shopify / theme-check

The Ultimate Shopify Theme Linter
Other
334 stars 96 forks source link

`with` variable being flagged as unused #606

Closed ConduciveMammal closed 2 years ago

ConduciveMammal commented 2 years ago

So using the below snippet with the subcollection variable, theme-check is flagging it as an unused variable. Did I miss something?

{% for subcollection_handle in collection.metafields.collection_banner.subcollections.value %}
  {% assign subcollection = collections[subcollection_handle] %}
  {% render 'subcollection' with subcollection %}
{% endfor %}
CleanShot 2022-07-14 at 3 43 48@2x
ConduciveMammal commented 2 years ago

Actually, just saw an existing issue for this at #582. Closing in favour 😊