search

Shopify / theme-check

The Ultimate Shopify Theme Linter
Other
338 stars 95 forks source link

Theme check failed with error #629

Closed bakura10 closed 2 years ago

bakura10 commented 2 years ago

Hi :),

I am running the latest version of ThemeCheck with Shopify CLI and it seems to hang up somewhere:

image

I am unable to find from where this is coming from. I could likely remove each file one by one to find which one may be causing the linter to fail, but maybe this can give some hint as to what could cause this? Our theme is super heavy, doing a file by file check would take quite a lot of time :D

charlespwd commented 2 years ago

Can you try running it with the theme-check gem instead? You should get a better error message. It looks like they are swallowing ours.

You can get it either via brew or rubygems.

bakura10 commented 2 years ago

Hi @charlespwd,

Sorry for the wrong alert, it is actually due to this: https://github.com/Shopify/theme-check/issues/625

Do you have a timeline as to when theme check is expected to be updated :)? The new version contains important fixes for us (those filters, but also all the warning due to the with attribute)

bakura10 commented 2 years ago

In the meantime, I'm closing this ticket. Thanks!

charlespwd commented 2 years ago

It's on my TODO list. I should probably do it today.