Shopify / theme-check

The Ultimate Shopify Theme Linter
Other
340 stars 96 forks source link

Introduce the `ObjectAttributeCompletionProvider` module #654

Closed karreiro closed 2 years ago

karreiro commented 2 years ago

Overview

The goal of this PR is fixing https://github.com/Shopify/theme-check/issues/642* and introducing new intelligent code completion capabilities on Theme Check.

I recommend reviewing this PR by following the sections below. I've split it into meaningful commits to approach each module individually and clarify its purpose.

Steps to review

1. Minor adjustments

2. Setup our new code completion tools

3. Improve our code completion suggestions

4. The new ObjectAttributeCompletionProvider provider

5. TODO

Steps to 🎩


* I've been calling the features introduced by this PR as "type inference" in https://github.com/Shopify/theme-check/issues/642 issue. But, I've decided to break that concept into sub-components into this PR to clarify what each phase means.